feat: implement idempotent soft delete for Books #4
+132
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements idempotent soft delete functionality for the Book resource following TDD principles. The implementation marks books as deleted rather than physically removing them, supporting audit requirements and data recovery needs.
Key Changes:
- Added
deleteBookByIdmethod with idempotent behavior ensuring repeated deletions don't trigger unnecessary database writes - Comprehensive test coverage including success, not found, and idempotency scenarios
- Custom
ResourceNotFoundExceptionto handle business logic failures distinct from framework exceptions
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/codesungrape/hmcts/bookapi/service/BookService.java | Implements soft delete with @Transactional annotation and idempotent logic |
| src/test/java/com/codesungrape/hmcts/bookapi/BookServiceTest.java | Adds unit tests covering successful deletion, not found exception, and idempotency |
| src/main/java/com/codesungrape/hmcts/bookapi/exception/ResourceNotFoundException.java | New custom runtime exception for resource not found scenarios |
| build.gradle | Enhances JaCoCo report output with file path printing |
| README.md | Updates JaCoCo report file path to reflect actual location |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/test/java/com/codesungrape/hmcts/bookapi/BookServiceTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/codesungrape/hmcts/bookapi/service/BookService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/codesungrape/hmcts/bookapi/service/BookService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/codesungrape/hmcts/bookapi/service/BookService.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the "Soft Delete" functionality for the Book resource using a TDD approach. It ensures data is marked as deleted rather than physically removed, supporting audit requirements and data recovery.
Changes:
Technical Decisions: